old4ever/ca-marketplace-scraper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: add maxItems support to ebay scraper

Browse Source
This commit is contained in:
Dmytro Stanchiev
2026-04-27 10:56:23 -04:00
parent 02b3f805b2
commit b6456047a6
4 changed files with 130 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/core/src/scrapers/ebay.ts
View File

@@ -394,6 +394,7 @@ export default async function fetchEbayItems(
keywords?: string[];
buyItNowOnly?: boolean;
canadaOnly?: boolean;
maxItems?: number;
} | undefined,
unstableMode: { hideUnstableResults: true },
): Promise<UnstableListingBuckets<EbayListingDetails>>;
@@ -408,6 +409,7 @@ export default async function fetchEbayItems(
keywords?: string[];
buyItNowOnly?: boolean;
canadaOnly?: boolean;
maxItems?: number;
},
unstableMode?: UnstableListingModeOptions,
): Promise<EbayListingDetails[]>;
@@ -422,21 +424,12 @@ export default async function fetchEbayItems(
keywords?: string[];
buyItNowOnly?: boolean;
canadaOnly?: boolean;
maxItems?: number;
} = {},
unstableMode: UnstableListingModeOptions = {},
) {
const requestsPerSecond = REQUESTS_PER_SECOND > 0 ? REQUESTS_PER_SECOND : 1;
const finalizeResults = (
listings: EbayListingDetails[],
): EbayListingDetails[] | UnstableListingBuckets<EbayListingDetails> => {
if (!unstableMode.hideUnstableResults) {
return listings;
}
return classifyUnstableListings(listings);
};
const {
minPrice = 0,
maxPrice = Number.MAX_SAFE_INTEGER,
@@ -445,8 +438,22 @@ export default async function fetchEbayItems(
keywords = [SEARCH_QUERY], // Default to search query if no keywords provided
buyItNowOnly = true,
canadaOnly = true,
maxItems,
} = opts;
const finalizeResults = (
listings: EbayListingDetails[],
): EbayListingDetails[] | UnstableListingBuckets<EbayListingDetails> => {
const limitedListings =
maxItems !== undefined ? listings.slice(0, maxItems) : listings;
if (!unstableMode.hideUnstableResults) {
return limitedListings;
}
return classifyUnstableListings(limitedListings);
};
const cookies = await loadEbayCookies();
// Build eBay search URL - use Canadian site, Buy It Now filter, and Canada-only preference

82
packages/core/test/ebay-core.test.ts
View File

@@ -552,4 +552,86 @@ describe("eBay Scraper Cookie Handling", () => {
],
});
});
test("respects maxItems in default mode", async () => {
global.fetch = mock(() =>
Promise.resolve({
ok: true,
text: () =>
Promise.resolve(`
<html><body>
<li class="s-item">
<a href="https://www.ebay.ca/itm/1"></a>
<h3>First Bundle</h3>
<span class="s-item__price">CA $100.00</span>
</li>
<li class="s-item">
<a href="https://www.ebay.ca/itm/2"></a>
<h3>Second Bundle</h3>
<span class="s-item__price">CA $110.00</span>
</li>
<li class="s-item">
<a href="https://www.ebay.ca/itm/3"></a>
<h3>Third Bundle</h3>
<span class="s-item__price">CA $70.00</span>
</li>
</body></html>
`),
}),
) as typeof fetch;
const results = await fetchEbayItems("laptop", 1000, { maxItems: 2 });
expect(results).toHaveLength(2);
expect(results[0]).toEqual(
expect.objectContaining({ title: "First Bundle" }),
);
expect(results[1]).toEqual(
expect.objectContaining({ title: "Second Bundle" }),
);
});
test("respects maxItems in unstable mode", async () => {
global.fetch = mock(() =>
Promise.resolve({
ok: true,
text: () =>
Promise.resolve(`
<html><body>
<li class="s-item">
<a href="https://www.ebay.ca/itm/1"></a>
<h3>First Bundle</h3>
<span class="s-item__price">CA $100.00</span>
</li>
<li class="s-item">
<a href="https://www.ebay.ca/itm/2"></a>
<h3>Second Bundle</h3>
<span class="s-item__price">CA $110.00</span>
</li>
<li class="s-item">
<a href="https://www.ebay.ca/itm/3"></a>
<h3>Third Bundle</h3>
<span class="s-item__price">CA $70.00</span>
</li>
</body></html>
`),
}),
) as typeof fetch;
const results = await fetchEbayItems(
"laptop",
1000,
{ maxItems: 2 },
{ hideUnstableResults: true },
);
expect(results.results).toHaveLength(2);
expect(results.unstableResults).toHaveLength(0);
expect(results.results[0]).toEqual(
expect.objectContaining({ title: "First Bundle" }),
);
expect(results.results[1]).toEqual(
expect.objectContaining({ title: "Second Bundle" }),
);
});
});