fix: validate route params and reduce duplication

packages/api-server/test/routes.test.ts

@@ -26,12 +26,6 @@ describe("API routes", () => {
     );
   });
 
-  afterEach(() => {
-    fetchFacebookItems.mockClear();
-    fetchEbayItems.mockClear();
-    fetchKijijiItems.mockClear();
-  });
-
   test("facebookRoute ignores cookies query parameter", async () => {
     const { facebookRoute } = await import("../src/routes/facebook");
 
@@ -81,8 +75,8 @@ describe("API routes", () => {
         location: undefined,
         category: undefined,
         keywords: undefined,
-        sortBy: null,
-        sortOrder: null,
+        sortBy: undefined,
+        sortOrder: undefined,
         maxPages: 3,
         priceMin: undefined,
         priceMax: undefined,
@@ -166,8 +160,8 @@ describe("API routes", () => {
         location: undefined,
         category: undefined,
         keywords: undefined,
-        sortBy: null,
-        sortOrder: null,
+        sortBy: undefined,
+        sortOrder: undefined,
         maxPages: 5,
         priceMin: undefined,
         priceMax: undefined,
@@ -261,8 +255,8 @@ describe("API routes", () => {
         location: undefined,
         category: undefined,
         keywords: undefined,
-        sortBy: null,
-        sortOrder: null,
+        sortBy: undefined,
+        sortOrder: undefined,
         maxPages: 5,
         priceMin: undefined,
         priceMax: undefined,
@@ -289,8 +283,8 @@ describe("API routes", () => {
         location: undefined,
         category: undefined,
         keywords: undefined,
-        sortBy: null,
-        sortOrder: null,
+        sortBy: undefined,
+        sortOrder: undefined,
         maxPages: 5,
         priceMin: undefined,
         priceMax: undefined,
@@ -429,4 +423,53 @@ describe("API routes", () => {
     expect(body.results[0].title).toBe("a");
     expect(body.unstableResults[0].title).toBe("d");
   });
+
+  test("ebayRoute returns 404 when unstable results are empty", async () => {
+    const { ebayRoute } = await import("../src/routes/ebay");
+
+    fetchEbayItems.mockImplementation(() =>
+      Promise.resolve({
+        results: [],
+        unstableResults: [],
+      }),
+    );
+
+    const response = await ebayRoute(
+      new Request(
+        "http://localhost/api/ebay?q=laptop&unstableFilter=true",
+      ),
+    );
+
+    expect(response.status).toBe(404);
+    const body = await response.json();
+    expect(body.message).toBe("Search didn't return any results!");
+  });
+
+  test("ebayRoute returns 400 for invalid maxItems", async () => {
+    const { ebayRoute } = await import("../src/routes/ebay");
+
+    const response = await ebayRoute(
+      new Request(
+        "http://localhost/api/ebay?q=laptop&maxItems=abc",
+      ),
+    );
+
+    expect(response.status).toBe(400);
+    const body = await response.json();
+    expect(body.message).toBe("Invalid maxItems parameter");
+  });
+
+  test("facebookRoute returns 400 for invalid maxItems", async () => {
+    const { facebookRoute } = await import("../src/routes/facebook");
+
+    const response = await facebookRoute(
+      new Request(
+        "http://localhost/api/facebook?q=laptop&maxItems=abc",
+      ),
+    );
+
+    expect(response.status).toBe(400);
+    const body = await response.json();
+    expect(body.message).toBe("Invalid maxItems parameter");
+  });
 });